Skip to content
This repository was archived by the owner on Jan 14, 2020. It is now read-only.

Shortens Sharing Links #383

Open
redreceipt wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Shortens Sharing Links #383

redreceipt wants to merge 3 commits into from

Conversation

@redreceipt
Copy link
Contributor

@redreceipt redreceipt commented Nov 13, 2019 •
edited
Loading

DESCRIPTION

Screen Shot 2019-11-13 at 11 30 28 AM

What does this PR do, or why is it needed?

Creates a short link for content to use in sharing.

How do I test this PR?

Query some content and include sharing.url

TODO

  • I am affirming this is my best work (Ecclesiastes 9:10)
  • PR has a relevant title that will be understandable in a public changelog (ie...non developers)
  • No new warnings in tests, in storybook, and in-app
  • Upload GIF(s) of iOS and Android if applicable
  • Set a relevant reviewer

REVIEW

  • Review updates to test coverage and snapshots
  • Review code through the lens of being concise, simple, and well-documented

Manual QA

  • Manual QA on iOS and ensure it looks/behaves as expected
  • Manual QA on Android and ensure it looks/behaves as expected

The purpose of PR Review is to improve the quality of the software.

@redreceipt redreceipt added the ready for review This is ready to be reviewd label Nov 13, 2019
@codecov-io
Copy link

codecov-io commented Nov 13, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (develop@dc7f778). Click here to learn what that means.
The diff coverage is 12.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #383   +/-   ##
==========================================
  Coverage           ?   46.22%           
==========================================
  Files              ?      169           
  Lines              ?     1616           
  Branches           ?      172           
==========================================
  Hits               ?      747           
  Misses             ?      767           
  Partials           ?      102
Impacted Files Coverage Δ
...s-church-api/src/data/content-items/data-source.js 21.34% <12.5%> (ø)

@redreceipt redreceipt added discussion Some discussion is needed to move forward and removed ready for review This is ready to be reviewd labels Nov 17, 2019
@redreceipt
Copy link
Contributor Author

redreceipt commented Nov 17, 2019

I want to make sure this is what we want to do before moving forward

cc @FrankGrand

@FrankGrand
Copy link

FrankGrand commented Nov 18, 2019

@redreceipt I'm not sure I understand the importance/relevance of this

@redreceipt
Copy link
Contributor Author

redreceipt commented Nov 18, 2019

Just thought it was cool and would save characters in a text message

@redreceipt redreceipt added ready for review This is ready to be reviewd blocked Blocked by another PR and removed discussion Some discussion is needed to move forward labels Nov 18, 2019
@redreceipt
Copy link
Contributor Author

redreceipt commented Nov 21, 2019

should decide on #381 first

@redreceipt
Copy link
Contributor Author

redreceipt commented Nov 21, 2019

also blocked by #412

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@richarddubay richarddubay Awaiting requested review from richarddubay

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

blocked Blocked by another PR ready for review This is ready to be reviewd

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@redreceipt @codecov-io @FrankGrand